Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing type hints to dbt/core/version.py #10612

Closed
1 task done
QMalcolm opened this issue Aug 27, 2024 · 0 comments · Fixed by #10613
Closed
1 task done

Add missing type hints to dbt/core/version.py #10612

QMalcolm opened this issue Aug 27, 2024 · 0 comments · Fixed by #10613
Assignees
Labels
tidy_first "Tidy First" incremental cleanup changes

Comments

@QMalcolm
Copy link
Contributor

Housekeeping

  • I am a maintainer of dbt-core

Short description

We're putting some effort into improving our typing. There are two type errors in dbt/core/version.py, we should fix them.

core/dbt/version.py:52: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
core/dbt/version.py:211: error: Unused "type: ignore" comment  [unused-ignore]

Acceptance criteria

dbt/core/verison.py doesn't have any type errros

Suggested Tests

N/A

Impact to Other Teams

None

Will backports be required?

No

Context

No response

@QMalcolm QMalcolm added the tidy_first "Tidy First" incremental cleanup changes label Aug 27, 2024
@QMalcolm QMalcolm self-assigned this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tidy_first "Tidy First" incremental cleanup changes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant