Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE-388] Add group metadata info to LogModelResult and LogTestResult #10775

Merged
merged 21 commits into from
Sep 26, 2024

Conversation

aranke
Copy link
Member

@aranke aranke commented Sep 25, 2024

Resolves CORE-388 #10745

Description

  1. We need to add group info to LogModelResult and LogTestResult for model-level notifications on node pass or fail.
    • Skipped nodes are not executed, so go through a separate LogSkipBecauseError message.
  2. Add attached_node to LogTestResult event if available to get model's FQN.
  3. Change Mashumaro serialization to include omit_none=True to prevent [Bug] Unable to parse dict error in logs if email property on a group is not specified #10745.
  4. Create core/dbt/task/group_lookup.py to centralize group lookup logic in one place and allow it to be accessed in both tasks and runners.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@cla-bot cla-bot bot added the cla:yes label Sep 25, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.03%. Comparing base (1fd4d2e) to head (c8cfe44).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10775   +/-   ##
=======================================
  Coverage   89.03%   89.03%           
=======================================
  Files         182      183    +1     
  Lines       23195    23215   +20     
=======================================
+ Hits        20651    20669   +18     
- Misses       2544     2546    +2     
Flag Coverage Δ
integration 86.24% <94.73%> (+<0.01%) ⬆️
unit 62.18% <44.73%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.18% <44.73%> (-0.02%) ⬇️
Integration Tests 86.24% <94.73%> (+<0.01%) ⬆️

@rviswanathan-dbt
Copy link

@aranke to check on skipped status for LogModelResult

@aranke aranke changed the title [CORE-388] Log group metadata info for result logs [CORE-388] Add group metadata info for LogModelResult and LogTestResult Sep 26, 2024
@aranke aranke changed the title [CORE-388] Add group metadata info for LogModelResult and LogTestResult [CORE-388] Add group metadata info to LogModelResult and LogTestResult Sep 26, 2024
@aranke aranke marked this pull request as ready for review September 26, 2024 13:36
@aranke aranke requested a review from a team as a code owner September 26, 2024 13:36
Copy link

@rviswanathan-dbt rviswanathan-dbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@aranke aranke merged commit 1076352 into main Sep 26, 2024
65 of 66 checks passed
@aranke aranke deleted the fix_core_388 branch September 26, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants