Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"dbt --version" should also emit plugin versions #2272

Closed
beckjake opened this issue Mar 31, 2020 · 1 comment · Fixed by #2279
Closed

"dbt --version" should also emit plugin versions #2272

beckjake opened this issue Mar 31, 2020 · 1 comment · Fixed by #2279
Labels
enhancement New feature or request

Comments

@beckjake
Copy link
Contributor

Describe the feature

dbt --version currently outputs the currently installed dbt version (and the most recently released one). It should also output the currently installed plugin versions.

Currently:

installed version: 0.16.0
   latest version: 0.16.0

Up to date!

I want:

installed dbt version: 0.16.0
   latest dbt version: 0.16.0

Plugins:
  - dbt-postgres: 0.16.0
  - dbt-redshift: 0.16.0
  - dbt-bigquery: 0.16.0
  - dbt-snowflake: 0.16.0

Up to date!

This feels kind of silly for the built-in plugins, but:

  • someday we're going to split the plugins that currently live in "core" out
  • this will make debugging third-party/external plugins much easier. I don't want to ask people to run pip freeze | grep dbt-spark to find out what version of the spark plugin they're on.

I think Up to date! will probably only refer to dbt-core, but I could be convinced otherwise. Extending it beyond core is probably more work, if we're worried about ambiguity.

the dbt-spark/dbt-presto adapters will have a dbt/adapters/{pluginname}/__version__.py - we should extend that pattern to the plugins that ship with core and use it.

Describe alternatives you've considered

Leave it as-is?

Who will this benefit?

What kind of use case will this feature be useful for? Please be specific and provide examples, this will help us prioritize properly.

  • developers/maintainers/people supporting external plugins
  • users who want to know what version of a plugin they're running
@beckjake beckjake added enhancement New feature or request triage labels Mar 31, 2020
@drewbanin drewbanin removed the triage label Mar 31, 2020
@sumanau7 sumanau7 mentioned this issue Mar 31, 2020
4 tasks
@sumanau7
Copy link
Contributor

@beckjake Let me know what you think ?
As a side note, when doing local development which branch should we take a checkout from ?

@drewbanin drewbanin added this to the Octavius Catto milestone Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants