Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing tests for create_adapter_plugin.py script #2295

Closed
beckjake opened this issue Apr 3, 2020 · 1 comment
Closed

Missing tests for create_adapter_plugin.py script #2295

beckjake opened this issue Apr 3, 2020 · 1 comment
Labels
adapter_plugins Issues relating to third-party adapter plugins bug Something isn't working repo ci/cd Testing and continuous integration for dbt-core + adapter plugins stale Issues that have gone stale

Comments

@beckjake
Copy link
Contributor

beckjake commented Apr 3, 2020

Describe the bug

There are no tests for create_adapter_plugin.py, so we are likely to regress again (see #2294 / #2145). We should add tests.

Expected behavior

Features we care about should have tests!
@beckjake beckjake added bug Something isn't working triage labels Apr 3, 2020
@drewbanin drewbanin added repo ci/cd Testing and continuous integration for dbt-core + adapter plugins and removed triage labels Apr 6, 2020
@jtcohen6 jtcohen6 added the adapter_plugins Issues relating to third-party adapter plugins label Jul 29, 2020
@github-actions
Copy link
Contributor

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please remove the stale label or comment on the issue, or it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues that have gone stale label Nov 23, 2021
@github-actions github-actions bot closed this as completed Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
adapter_plugins Issues relating to third-party adapter plugins bug Something isn't working repo ci/cd Testing and continuous integration for dbt-core + adapter plugins stale Issues that have gone stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@beckjake @drewbanin @jtcohen6