Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split node selection out from graph creation #2362

Closed
beckjake opened this issue Apr 27, 2020 · 1 comment
Closed

Split node selection out from graph creation #2362

beckjake opened this issue Apr 27, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@beckjake
Copy link
Contributor

Describe the feature

Currently, dbt selects tests as a mandatory part of the node selection process: After normal selection is done, dbt just adds every test that descends from the selected nodes.

Instead, dbt should only do that for tests. To accomplish this, dbt should split out node selection into "node selection" and "DAG creation", as discussed in #2203. The DAG creation step for dbt test is where test nodes should come into play.

This PR should also try to handle ephemeral nodes, but if that's hard it can wait.

Who will this benefit?

This will make it easier to explain selection in dbt. This will lay groundwork for some future work with more granular test selection, node selection, and dbt run+test

@beckjake beckjake added enhancement New feature or request triage labels Apr 27, 2020
@drewbanin drewbanin removed the triage label Apr 27, 2020
@drewbanin
Copy link
Contributor

closing in favor of #2328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants