Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

condA != condB not supported in TSQL #3001

Closed
dataders opened this issue Jan 8, 2021 · 0 comments · Fixed by #3000
Closed

condA != condB not supported in TSQL #3001

dataders opened this issue Jan 8, 2021 · 0 comments · Fixed by #3000
Labels
adapter_plugins Issues relating to third-party adapter plugins bug Something isn't working

Comments

@dataders
Copy link
Contributor

dataders commented Jan 8, 2021

snapshot_check_strategy() is not dispatched, which means it can only be overridden in a custom adapter. Which was working for dbt-sqlserver but we can't import that overwritten macro into dbt-synapse like we're doing with all the other properly dispatched macros.

rather than dispatching the entire snapshot_check_strategy(), we can, with a simple tweak to logic, modify it so that it works on TSQL but doesn't break the existing adapters.

The benefit is a lower code footprint which means the dbt-msft adapters can stay more current with dbt-core

@dataders dataders added bug Something isn't working triage labels Jan 8, 2021
@dataders dataders mentioned this issue Jan 8, 2021
4 tasks
@jtcohen6 jtcohen6 added adapter_plugins Issues relating to third-party adapter plugins and removed triage labels Jan 10, 2021
@jtcohen6 jtcohen6 added this to the Kiyoshi Kuromiya milestone Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adapter_plugins Issues relating to third-party adapter plugins bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants