-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor use_profile
#3193
Comments
@JCZuurmond Thanks for opening this, and sharing your thoughts! I appreciate the time you've spent diving into dbt's testing patterns, and the subsequent befuddlement. Today, dbt integration tests use the I think dbt contributors tend to be a mix of folks with plenty of prior python experience, prior OSS contributing experience, and none of either. In abstract, I like the idea of being less "special," where possible, so that folks can benefit from the vast trove of python/pytest documentation online. |
Yes, you said it perfectly. I think we - the dbt project - would benefit from I myself was bent over the "random" assert error, I did not easily make the link between the |
This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please remove the stale label or comment on the issue, or it will be closed in 7 days. |
This one still feels compelling to me. We should aim to rework our integration testing framework so that it is much less "special," and much more accessible to community contributors. Using more Alternative proposition: |
This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please remove the stale label or comment on the issue, or it will be closed in 7 days. |
Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest; add a comment to notify the maintainers. |
During my work on pr #3176 (@jtcohen6 and @kwigley) I broke my head over the
use_profile
decorator. As I understand it does two things:_profile_from_test_name
IMHO both are unexpected, especially if you are new to
dbt
. What is the goal of this decorator?My assumption is that we intend to do two things:
profile_postgres
you must havepostgres
in your name. Why do we want this? I think this is not needed, if we want it we could write a test for this.I think this would allow us to replace
use_profile(<profile name>)
with@pytest.mark.profile_<profile name>
, which is easier to understandThe text was updated successfully, but these errors were encountered: