Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warnings for renamed commands #3565

Closed
kwigley opened this issue Jul 13, 2021 · 4 comments
Closed

Add deprecation warnings for renamed commands #3565

kwigley opened this issue Jul 13, 2021 · 4 comments
Labels
enhancement New feature or request stale Issues that have gone stale

Comments

@kwigley
Copy link
Contributor

kwigley commented Jul 13, 2021

Describe the feature

In #3554, we renamed source snapshot-freshness -> source freshness. Both commands are supported and no deprecation warning is showed. It would be ideal to show deprecation warnings when using the old command.

Describe alternatives you've considered

Support renamed commands forever via an alias and don't display any deprecation warnings. I'm perfectly happy with this answer as well, I'd happily close this issue if that is acceptable.

@jtcohen6
Copy link
Contributor

I agree! Let's do both: continue support source snapshot-freshness as an alias forever*, and raise a deprecation warning when it's used.

*At least until dbt v2.0, if not longer :)

@github-actions
Copy link
Contributor

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please remove the stale label or comment on the issue, or it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues that have gone stale label Jan 14, 2022
@kwigley kwigley reopened this Jan 24, 2022
@kwigley kwigley removed the stale Issues that have gone stale label Jan 24, 2022
@github-actions
Copy link
Contributor

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please remove the stale label or comment on the issue, or it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues that have gone stale label Jul 24, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2022

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest; add a comment to notify the maintainers.

@github-actions github-actions bot closed this as completed Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale Issues that have gone stale
Projects
None yet
Development

No branches or pull requests

2 participants