Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-paths should default to "tests" not "test" #4011

Closed
jpeak-intellify opened this issue Oct 6, 2021 · 1 comment
Closed

test-paths should default to "tests" not "test" #4011

jpeak-intellify opened this issue Oct 6, 2021 · 1 comment
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@jpeak-intellify
Copy link

Describe the bug

dbt init sets up the dbt_project.yml with some default paths.
I wanted to cleanup my dbt_project.yml by removing these assuming I used the default values and folder names.

Turns out the default value for test-paths is test-paths: ["test"].
Where as the default that dbt init creates is test-paths: ["tests"].

This seems inconsistent.

https://docs.getdbt.com/reference/project-configs/test-paths

Could the default value be:
A) Changed to look for "tests" so it matches dbt init OR
B) Change the default value to look for both "test" and "tests".

It is nice that dbt init makes these visible initially to let me know what is available.

However if I don't change these from the defaults I would like to declutter my dbt_project.yml and remove them and have consistent behaviour.

I haven't double checked seeds, snapshots, etc.

@jpeak-intellify jpeak-intellify added bug Something isn't working triage labels Oct 6, 2021
@jtcohen6
Copy link
Contributor

jtcohen6 commented Oct 6, 2021

@jpeak-intellify Agreed!! You have great timing. We just opened a PR to finally fix this, in the lead-up to v1.0: #4007

In the meantime, I'm going to close this as a dupe of the original issue (#2659)

@jtcohen6 jtcohen6 added duplicate This issue or pull request already exists and removed triage labels Oct 6, 2021
@jtcohen6 jtcohen6 closed this as completed Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants