You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Folks who've newly upgraded to v1.0 are seeing a lot of warn-level (stdout) messages about tests defined on disabled models. This is what our internal analytics project looks like, and I don't think it's an uncommon experience:
(There's many more below that)
It is desirable to warn about tests that have "missed" the correct model, such as due to a typo in a ref or yaml property (e.g. see #4532). It's also a very common pattern to disable unused/irrelevant models in packages, and the result is a quite cluttered terminal. There are some useful warnings in there (missing node for patch), lost as needles in haystack-traces.
What I proposed in one of the threads linked above:
If a test depends on a disabled model, log this as DEBUG-level (shows up in logs/dbt.log)
If a test depends on a missing model, log this as WARN-level (shows up in standard CLI output)
I looked quickly at the code, and turns out this was actually our previous behavior:
github-actionsbot
changed the title
Restore previous behavior when a test depends on a disabled (vs. missing) resource
[CT-71] Restore previous behavior when a test depends on a disabled (vs. missing) resource
Jan 19, 2022
Prompted by Slack threads here + here
Folks who've newly upgraded to v1.0 are seeing a lot of warn-level (stdout) messages about tests defined on disabled models. This is what our internal analytics project looks like, and I don't think it's an uncommon experience:
(There's many more below that)
It is desirable to warn about tests that have "missed" the correct model, such as due to a typo in a
ref
or yaml property (e.g. see #4532). It's also a very common pattern to disable unused/irrelevant models in packages, and the result is a quite cluttered terminal. There are some useful warnings in there (missing node for patch), lost as needles in haystack-traces.What I proposed in one of the threads linked above:
I looked quickly at the code, and turns out this was actually our previous behavior:
dbt-core/core/dbt/parser/manifest.py
Lines 790 to 803 in 08b2f16
We've since replaced the first of those with a call to the
InvalidRefInTestNode
event, so this would just look like changing:dbt-core/core/dbt/events/types.py
Lines 1186 to 1192 in a588607
To:
Voila, just the good stuff:
The text was updated successfully, but these errors were encountered: