-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CT-371] [Bug] CLI vars in packages.yml and selectors.yml don't work. #4876
Comments
4 tasks
leahwicz
changed the title
[Bug] CLI vars in packages.yml and selectors.yml don't work.
[CT-371] [Bug] CLI vars in packages.yml and selectors.yml don't work.
Mar 16, 2022
@gshank Thanks for looking into this! Glad we caught it during our collective triage time the other day... Given how straightforward the fix for this is, it feels like something we'd want to include in the next patch release. Do folks agree? I know we'd been planning to cut v1.0.4rc1 today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When we did the work to separate out rendering of secrets, a bug was introduced where instead of using cli_vars to construct the contexts for packages and selectors, we use the entire yaml context (which is also a dict). Because of this we get errors like: "Object of type method is not JSON serializable" and also vars are not found when rendering.
The text was updated successfully, but these errors were encountered: