-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CT-729] [Bug] unrendered_config in manifest.json doesn't update correctly from model properties yaml #5338
Comments
Agree that #3576 and #3680 are related to the larger topic here, but actually separate from the specific bug reported here. The bug here seems much easier to reproduce, and (hopefully) to get to the bottom of why configurations defined in standard Ideally,
We'd store that whole Jinja expression, rather than As a practical matter, even just storing |
Is there an existing issue for this?
Current Behavior
Config changes from model properties yaml are not correctly propagated to the manifest.json, thus not showing up as a state change when using the
state:modified
selector.Expected Behavior
I expect the config changes from the model properties yaml to be correctly propagated to the
manifest.json
- "unrendered_config", just like it does from the config changes made indbt_project.yml
.This will fix the state:modified selector to correctly detect my config changes made in the model properties yaml files.
Steps To Reproduce
dbt compile
. Look forcustomers
model intarget/manifest.json
- has"unrendered_config": {"materialized": "table"}
target/manifest.json
to top directory.models/schemas.yaml
and add the config block for customers model.dbt compile
. Look forcustomers
model intarget/manifest.json
- still has"unrendered_config": {"materialized": "table"}
. The materialization config change hasn't been propagated5-1. Side-effect (which is the real problem for me): Run
dbt ls -s state:modified --state .
dbt_project.yml
, and update the model config as below:dbt compile
. Look forcustomers
model intarget/manifest.json
- now the updated config is shown here:"unrendered_config": {"materialized": "table"}
.7-1. Run
dbt ls -s state:modified --state .
I expect the same result from step 5-1.
Relevant log output
No response
Environment
What database are you using dbt with?
bigquery
Additional Context
Similar issue is reported for the jinja config macro:
#3680
But the fix for the jinja config macro won't necessarily fix this issue.
The text was updated successfully, but these errors were encountered: