Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-845] Rename try_* -> strict_* #5475

Closed
jtcohen6 opened this issue Jul 15, 2022 · 1 comment · Fixed by #5478
Closed

[CT-845] Rename try_* -> strict_* #5475

jtcohen6 opened this issue Jul 15, 2022 · 1 comment · Fixed by #5478
Labels
tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Milestone

Comments

@jtcohen6
Copy link
Contributor

Follow-up to #5107, #5167

Let's rename:

  • try_setset_strict
  • try_zipzip_strict

Big idea is that strict_ methods:

  • should raise a standard exception if the value cannot be converted to a set / yaml / json, zipped, etc
  • should not not allow for a default value to gracefully (silently) fail over to

Timeline:

  • Immediate (before Tuesday): Rename these for the second RC of v1.2.0
  • Medium-term: Add fromjson_strict, tojson_strict, fromyaml_strict, toyaml_strict following the same pattern
@jtcohen6 jtcohen6 added tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality Team:Language labels Jul 15, 2022
@github-actions github-actions bot changed the title Rename try_* → strict_* [CT-845] Rename try_* → strict_* Jul 15, 2022
@jtcohen6 jtcohen6 added this to the v1.2 milestone Jul 15, 2022
@jtcohen6 jtcohen6 changed the title [CT-845] Rename try_* → strict_* [CT-845] Rename try_* -> strict_* Jul 15, 2022
@jtcohen6
Copy link
Contributor Author

(I'm actually in the habit of typing → now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant