-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CT-1184] [Feature] Exposures: stricter validation for name
, support custom label
#5606
Closed
3 tasks done
Labels
Comments
github-actions
bot
changed the title
[Feature] Support "labels" on exposures, and stricter validation for names
[CT-982] [Feature] Support "labels" on exposures, and stricter validation for names
Aug 3, 2022
jtcohen6
changed the title
[CT-982] [Feature] Support "labels" on exposures, and stricter validation for names
[Feature] Exposures: stricter validation for Aug 3, 2022
na e, support custom
label`
jtcohen6
changed the title
[Feature] Exposures: stricter validation for
[Feature] Exposures: stricter validation for Aug 3, 2022
na e, support custom
label`name
, support custom label
Can we combine the name validation portion of this tickets with #5456 so we could use a single name validation function and then just have a separate ticket for adding labels? |
1 task
github-actions
bot
changed the title
[Feature] Exposures: stricter validation for
[CT-1184] [Feature] Exposures: stricter validation for Sep 14, 2022
name
, support custom label
name
, support custom label
6 tasks
Handling the associated questions in the linked PR — removing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is this your first time submitting a feature request?
Describe the feature
Currently, it's possible to define an exposure like:
A surprising number of things will keep working:
The problem is that it's not guaranteed to work everywhere. In particular, the
dbt-docs
site DAG selection does not handle exposure names with spaces (#2970).Rather than fix it everywhere, I'd prefer to adopt the same approach we'll be taking for metrics (#5456):
name
property of exposures: snake-case, alphanumeric characters, maybe periods (since this is supported for models)label
property that can be used in external metadata, and contain whatever characters the heart desiresDescribe alternatives you've considered
label
I don't like either very much!
Who will this benefit?
Are you interested in contributing this feature?
Perhaps :)
Anything else?
No response
The text was updated successfully, but these errors were encountered: