Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-1206] [Enhancement] test for saving pandas dataframe in python models #5881

Closed
3 tasks done
ChenyuLInx opened this issue Sep 19, 2022 · 0 comments · Fixed by #5906
Closed
3 tasks done

[CT-1206] [Enhancement] test for saving pandas dataframe in python models #5881

ChenyuLInx opened this issue Sep 19, 2022 · 0 comments · Fixed by #5906
Labels
enhancement New feature or request python_models

Comments

@ChenyuLInx
Copy link
Contributor

ChenyuLInx commented Sep 19, 2022 •
edited
Loading

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Add a test in basic adapter tests for python model to help testing save pandas dataframe as this becomes a standard thing that we would want to support
Related link
dbt-labs/dbt-bigquery#301
dbt-labs/dbt-spark#469

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response
@ChenyuLInx ChenyuLInx added enhancement New feature or request triage python Pull requests that update Python code and removed triage labels Sep 19, 2022
@github-actions github-actions bot changed the title [Enhancement] test for saving pandas dataframe in python models [CT-1206] [Enhancement] test for saving pandas dataframe in python models Sep 19, 2022
@ChenyuLInx ChenyuLInx added python_models and removed python Pull requests that update Python code labels Sep 21, 2022
@ChenyuLInx ChenyuLInx mentioned this issue Sep 21, 2022
Merged
5 tasks
@dbeatty10 dbeatty10 mentioned this issue Sep 24, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request python_models
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PySpark dataframe related tests dbt-labs/dbt-core
1 participant
@ChenyuLInx