Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-1643] [Bug] Deal with another change in tox behavior #6421

Closed
2 tasks done
peterallenwebb opened this issue Dec 11, 2022 · 1 comment
Closed
2 tasks done

[CT-1643] [Bug] Deal with another change in tox behavior #6421

peterallenwebb opened this issue Dec 11, 2022 · 1 comment
Labels
repo ci/cd Testing and continuous integration for dbt-core + adapter plugins tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@peterallenwebb
Copy link
Contributor

peterallenwebb commented Dec 11, 2022 •
edited
Loading

Is this a new bug in dbt-core?

  • I believe this is a new bug in dbt-core
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

The builds for 1.0.latest and 1.1.latest are failing because a recent change to tox yesterday (tox-dev/tox#2658) causes it to error out when it encounters passenv parameters separated by spaces. This is a bit different than the previous tox change that affected newer versions of dbt but the fix should be the same. In that case the spaces simply caused tox to ignore the parameters.

Expected Behavior

The 1.0.latest and 1.1.latest tests should pass.

Steps To Reproduce

The failures can be observed in the 1.0.latest and 1.1.latest CI pipelines.

Relevant log output

No response

Environment

- OS:
- Python:
- dbt:

Which database adapter are you using with dbt?

No response

Additional Context

No response
@peterallenwebb peterallenwebb added bug Something isn't working triage labels Dec 11, 2022
@github-actions github-actions bot changed the title [Bug] Deal with another change in tox behavior [CT-1643] [Bug] Deal with another change in tox behavior Dec 11, 2022
@peterallenwebb peterallenwebb mentioned this issue Dec 11, 2022
Closed
7 tasks
@dbeatty10 dbeatty10 removed the triage label Dec 12, 2022
@jtcohen6 jtcohen6 added repo ci/cd Testing and continuous integration for dbt-core + adapter plugins tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality and removed bug Something isn't working labels Dec 13, 2022
@peterallenwebb peterallenwebb mentioned this issue Dec 14, 2022
Merged
6 tasks
@MichelleArk MichelleArk mentioned this issue Dec 14, 2022
Merged
6 tasks
@jtcohen6
Copy link
Contributor

jtcohen6 commented Jan 5, 2023

Resolved by #6445 + #6446

@jtcohen6 jtcohen6 closed this as completed Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
repo ci/cd Testing and continuous integration for dbt-core + adapter plugins tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@peterallenwebb @jtcohen6 @dbeatty10