Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-1759] dbt parse should (over)write manifest.json by default #6534

Closed
jtcohen6 opened this issue Jan 6, 2023 · 3 comments
Closed

[CT-1759] dbt parse should (over)write manifest.json by default #6534

jtcohen6 opened this issue Jan 6, 2023 · 3 comments
Labels
cli enhancement New feature or request

Comments

@jtcohen6
Copy link
Contributor

jtcohen6 commented Jan 6, 2023

That's it, that's the issue.

if self.args.write_manifest:
fire_event(ParseCmdWritingManifest())
self.write_manifest()

I find it mildly annoying that I can't use just dbt parse, when all I want to do is update manifest.json with the latest project contents, often for manual inspection / debugging.

We can make this opt-out (with a --no-write-manifest argument), instead of opt-in (with a --write-manifest flag as it is today).

@jtcohen6 jtcohen6 added enhancement New feature or request cli Team:Language labels Jan 6, 2023
@github-actions github-actions bot changed the title dbt parse should (over)write manifest.json by default [CT-1759] dbt parse should (over)write manifest.json by default Jan 6, 2023
@gshank
Copy link
Contributor

gshank commented Jan 6, 2023

@jtcohen6 In my protobuf nodes branch I added a bit to write out the manifest.json when we write out the partial parse manifest. I hadn't thought about the implications for the "parse" command, but that change would have made the '--write-manifest' flag a no-op. (as a side note, when I wrote the parse command I wanted to write out the manifest.json but was overruled, so the --write-manifest thing was a compromise). I could pull that change out of the protobuf nodes branch if we want to move that bit up...

@jtcohen6
Copy link
Contributor Author

jtcohen6 commented Jan 6, 2023

as a side note, when I wrote the parse command I wanted to write out the manifest.json but was overruled, so the --write-manifest thing was a compromise

overruled! by me?? quite possibly

I could pull that change out of the protobuf nodes branch if we want to move that bit up...

I'm just happy to have this change happen, I don't feel strongly that it must happen immediately

@jtcohen6
Copy link
Contributor Author

Resolved by #6565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants