Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-1890] Reintroduce logging to manifest generation #6707

Closed
stu-k opened this issue Jan 24, 2023 · 3 comments
Closed

[CT-1890] Reintroduce logging to manifest generation #6707

stu-k opened this issue Jan 24, 2023 · 3 comments
Labels
logging stale Issues that have gone stale

Comments

@stu-k
Copy link
Contributor

stu-k commented Jan 24, 2023

As part of the work in #6565, event logging in the parse task was removed. This ticket captures the work to reintroduce it to ManifestLoader.get_full_manifest, likely behind an optional flag. I believe the best method to achieve this is to pass in the fire_event function to the method, defaulting to a noop function.

@github-actions github-actions bot changed the title Reintroduce logging to manifest generation [CT-1890] Reintroduce logging to manifest generation Jan 24, 2023
@gshank
Copy link
Contributor

gshank commented Jan 24, 2023

We also have a "fire_event_if" function in core/dbt/events/functions.py

Copy link
Contributor

github-actions bot commented Feb 5, 2024

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues that have gone stale label Feb 5, 2024
Copy link
Contributor

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logging stale Issues that have gone stale
Projects
None yet
Development

No branches or pull requests

3 participants