Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-2018] Performance Bottleneck in BaseRelation.get_relation() #6842

Closed
peterallenwebb opened this issue Feb 2, 2023 · 4 comments
Closed

[CT-2018] Performance Bottleneck in BaseRelation.get_relation() #6842

peterallenwebb opened this issue Feb 2, 2023 · 4 comments
Labels
adapter_caching Issues related to the adapter's relation cache enhancement New feature or request performance stale Issues that have gone stale

Comments

@peterallenwebb
Copy link
Contributor

peterallenwebb commented Feb 2, 2023 •
edited
Loading

A profile of @boxysean's "really big project" showed that 60% of the time of a dbt build run is spent in BaseRelation.get_relation(). Let's look at how we can improve the performance of this function in a way with substantial end-user impact.
@peterallenwebb peterallenwebb added the enhancement New feature or request label Feb 2, 2023
@github-actions github-actions bot changed the title Performance Bottleneck in BaseRelation.get_relation() [CT-2018] Performance Bottleneck in BaseRelation.get_relation() Feb 2, 2023
@jtcohen6 jtcohen6 added performance adapter_caching Issues related to the adapter's relation cache labels Feb 2, 2023
@boxysean
Copy link
Contributor

boxysean commented Feb 2, 2023

@peterallenwebb thanks for the nerd snipe 👀

@peterallenwebb
Copy link
Contributor Author

@boxysean It's not just a snipe, I have an improvement incoming. ;)

@peterallenwebb peterallenwebb mentioned this issue Feb 2, 2023
Closed
6 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues that have gone stale label Aug 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
adapter_caching Issues related to the adapter's relation cache enhancement New feature or request performance stale Issues that have gone stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Optimize BaseRelation.matches() dbt-labs/dbt-core
3 participants
@peterallenwebb @boxysean @jtcohen6