Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2028] A general solution for setting attributes in flag objects to consistent types #6857

Open
Tracked by #6706
MichelleArk opened this issue Feb 3, 2023 · 0 comments
Assignees
Labels
spike tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@MichelleArk
Copy link
Contributor

In the flag consolidation work done in API-ification phase 1, we introduced a method convert_config that converts the warn_error_options param as provided from a user config to the appropriate WarnErrorOptions.

Given that we define which type a param should be in cli.params, we can implement this casting more generally based on the click-configured type of the param instead of hardcoding it. This should apply for other params and types as well, so that they are consistently represented between Flags and params (e.g. Path params)

@MichelleArk MichelleArk added tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality Team:Execution labels Feb 3, 2023
@github-actions github-actions bot changed the title A general solution for setting attributes in flag objects to consistent types [CT-2028] A general solution for setting attributes in flag objects to consistent types Feb 3, 2023
@iknox-fa iknox-fa added Refinement Maintainer input needed spike and removed Refinement Maintainer input needed labels Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spike tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Development

No branches or pull requests

4 participants