You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This makes it difficult to test string types themselves in adapter overrides of this method.
To fix this, add an overridable schema_string_type fixture to BaseConstraintsColumnsEqual (can default to string_type), so that it can be overwritten in adapters that have variation between the string schema type and error message. schema_string_type should be used to set wrong_schema_data_type in BaseConstraintsColumnsEqual.test__constraints_wrong_column_data_types.
The text was updated successfully, but these errors were encountered:
github-actionsbot
changed the title
Add schema_int_type fixture to BaseConstraintsColumnsEqual
[CT-2269] Add schema_int_type fixture to BaseConstraintsColumnsEqual
Mar 4, 2023
MichelleArk
changed the title
[CT-2269] Add schema_int_type fixture to BaseConstraintsColumnsEqual
[CT-2269] Add schema_string_type fixture to BaseConstraintsColumnsEqual
Mar 27, 2023
Currently,
test__constraints_wrong_column_data_types
assumes the error message type and schema type for an adapter's string type are always the same. On some adapters (like spark!) this is not the case (e.g. valid schema.yml data_type is 'string', error message is 'STR' or 'STRING_TYPE' .This makes it difficult to test string types themselves in adapter overrides of this method.
To fix this, add an overridable
schema_string_type
fixture toBaseConstraintsColumnsEqual
(can default tostring_type
), so that it can be overwritten in adapters that have variation between the string schema type and error message.schema_string_type
should be used to setwrong_schema_data_type
inBaseConstraintsColumnsEqual.test__constraints_wrong_column_data_types
.The text was updated successfully, but these errors were encountered: