Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use IAM auth for Redshift #757

Closed
drewbanin opened this issue May 2, 2018 · 4 comments
Closed

use IAM auth for Redshift #757

drewbanin opened this issue May 2, 2018 · 4 comments
Labels
enhancement New feature or request redshift

Comments

@drewbanin
Copy link
Contributor

We can use boto3's get_cluster_credentials to get temp creds, then auth with those

@drewbanin drewbanin added enhancement New feature or request redshift labels May 2, 2018
@danielchalef
Copy link
Contributor

I'd be happy to contribute this. Would you recommend I subclass and extend RedshiftAdapter or modify RedshiftAdapter?

@drewbanin
Copy link
Contributor Author

hey @danielchalef - that's great! I would just modify the RedshiftAdapter. We have different methods for authing with BigQuery -- you may be able to use some of that code as an example.

Happy to help here however I can!

@danielchalef
Copy link
Contributor

See PR #769 . Let me know if you'd like any mods. I noticed that the PR did not pass a codeclimate check.

@drewbanin
Copy link
Contributor Author

Just merged #818 to add support for this feature. Thanks for the suggestion and the initial implementation @danielchalef :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request redshift
Projects
None yet
Development

No branches or pull requests

3 participants