Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2644] [Feature] Remove dependency on sqlparse #7791

Closed
3 tasks done
emmyoop opened this issue Jun 5, 2023 · 5 comments
Closed
3 tasks done

[CT-2644] [Feature] Remove dependency on sqlparse #7791

emmyoop opened this issue Jun 5, 2023 · 5 comments
Assignees
Labels
dependencies Changes to the version of dbt dependencies enhancement New feature or request

Comments

@emmyoop
Copy link
Member

emmyoop commented Jun 5, 2023

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Remove the dependency on sqlparse comp;letely.

Currently we only use sqlparse here. Remove the sqlparse dependency and replace the logic with our own manual version.

Describe alternatives you've considered

#7515

@emmyoop emmyoop added enhancement New feature or request triage labels Jun 5, 2023
@github-actions github-actions bot changed the title [Feature] Remove dependency on sqlparse [CT-2644] [Feature] Remove dependency on sqlparse Jun 5, 2023
@jtcohen6 jtcohen6 added dependencies Changes to the version of dbt dependencies and removed triage labels Jun 5, 2023
@lukehsiao
Copy link

While the sqlparse vuln is only considered moderate by GitHub, it is considered high by NIST: https://nvd.nist.gov/vuln/detail/CVE-2023-30608

Curious if there is any estimate on when this removal might be implemented?

@kovaacs
Copy link

kovaacs commented Jun 15, 2023

Is this really a "feature?" As far as I'm concerned, this is a fix for a high vulnerability in a pinned dependency.

@jtcohen6
Copy link
Contributor

@lukehsiao @kovaacs Heard! This is high priority for us, and we're going to try tackling in our upcoming sprint.

@bdashrad
Copy link

Any idea when could we expect a fix for this to go out? The high severity CVE-2023-30608 is fixed by it.

@jtcohen6
Copy link
Contributor

After spiking what would be required for a full replacement (#7919), and also endeavoring to reproduce the error we were seeing (only in CI, only on Ubuntu) — we've decided that supporting sqlparse==0.4.4 is the right move for now (#7929).

As such, I'm going to close this issue in favor of reopening #7515. We'll be including that change in v1.6, and in the next patch release of v1.5.x.

@jtcohen6 jtcohen6 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes to the version of dbt dependencies enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants