Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2709] Generalize manifest.public_node #7890

Closed
Tracked by #7372
MichelleArk opened this issue Jun 16, 2023 · 0 comments · Fixed by #7891
Closed
Tracked by #7372

[CT-2709] Generalize manifest.public_node #7890

MichelleArk opened this issue Jun 16, 2023 · 0 comments · Fixed by #7891
Assignees
Labels
tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@MichelleArk
Copy link
Contributor

MichelleArk commented Jun 16, 2023

The initial implementation of resolving refs to models from upstream projects significantly special-cased the storage and handling of "upstream public nodes". It led to some unnecessary duplication to achieve the same behaviours that model nodes defined within a project had -- a node that can be referenced, selected (via list / --select syntax) and executed (depending on its presence of raw code).

This can be reconciled by handling upstream public nodes much like dbt currently handles models from upstream packages to avoid duplication and make the implementation more straightforward to reason about. manifest.nodes already stores a collection of generic nodes that are part of dbt's DAG -- including those defined by other projects (i.e. packages), and should be reused to store public nodes (as ModelNodes), injected at the end of parsing.

@MichelleArk MichelleArk added the tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality label Jun 16, 2023
@MichelleArk MichelleArk self-assigned this Jun 16, 2023
@github-actions github-actions bot changed the title Generalize manifest.public_node [CT-2709] Generalize manifest.public_node Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant