Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2898] [Feature] Enable merge_exclude_columns test for dbt-postgres #8267

Closed
dbeatty10 opened this issue Aug 1, 2023 · 1 comment · Fixed by #8268
Closed

[CT-2898] [Feature] Enable merge_exclude_columns test for dbt-postgres #8267

dbeatty10 opened this issue Aug 1, 2023 · 1 comment · Fixed by #8268
Labels
enhancement New feature or request

Comments

@dbeatty10
Copy link
Contributor

dbeatty10 commented Aug 1, 2023

Current Behavior

The source code here doesn't include TestMergeExcludeColumns like dbt-snowflake does here or dbt-redshift does here.

This is because merge wasn't a supported incremental strategy for dbt-postgres until 1.6 and adding relevant functional tests was overlooked during implementation in #6951.

Expected Behavior

e.g. I expected the end of the file to look like this:

class TestMergeExcludeColumns(BaseMergeExcludeColumns):
    pass

Steps To Reproduce

See above for context.

Relevant log output

No response

Environment

- OS:
- Python:
- dbt:

Which database adapter are you using with dbt?

No response

Additional Context

Due to a misunderstanding how this feature should behave, I originally thought the expected output should look like this, but I was mistaken! dbt-labs/dbt-redshift#564 brought dbt-redshift in line with the behavior of other adapters.

@dbeatty10 dbeatty10 added bug Something isn't working triage and removed triage labels Aug 1, 2023
@github-actions github-actions bot changed the title [Bug] merge_exclude_columns is untested for dbt-postgres [CT-2898] [Bug] merge_exclude_columns is untested for dbt-postgres Aug 1, 2023
@dbeatty10 dbeatty10 added enhancement New feature or request and removed bug Something isn't working labels Aug 2, 2023
@dbeatty10 dbeatty10 changed the title [CT-2898] [Bug] merge_exclude_columns is untested for dbt-postgres [CT-2898] [Feature] Enable merge_exclude_columns test for dbt-postgres Aug 2, 2023
Copy link
Contributor

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues that have gone stale label Jan 30, 2024
@dbeatty10 dbeatty10 removed the stale Issues that have gone stale label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant