Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-3326] [Regression] Deferral and Retry fail in 1.7 if you don't have a run *without* deferral using 1.7 first #9010

Closed
2 tasks done
martynydbt opened this issue Nov 6, 2023 · 0 comments · Fixed by #9009
Assignees

Comments

@martynydbt
Copy link

Is this a regression in a recent version of dbt-core?

  • I believe this is a regression in dbt-core functionality
  • I have searched the existing issues, and I could not find an existing issue for this regression

Current Behavior

If a user upgrades from anything <1.7 to 1.7, then deferral and dbt retry are going to fail with the error.

Runtime Error
 Expected a schema version of "https://schemas.getdbt.com/dbt/run-results/v5.json" in /tmp/defer-artifacts/run_results.json, but found "https://schemas.getdbt.com/dbt/run-results/v4.json". Are you running with a different version of dbt?

Expected/Previous Behavior

For it to defer or retry successfully after upgrading.

Steps To Reproduce

  1. Take a project running a version older than 1.7 and using deferral.
  2. Upgrade it to 1.7
  3. Re-run a job from a point of failure.

Relevant log output

No response

Environment

- OS:
- Python:
- dbt (working version): anything before 1.7.0
- dbt (regression version): 1.7.0

Which database adapter are you using with dbt?

other (mention it in "Additional Context")

Additional Context

Feedback from @jtcohen6 :

  • The way we've handled this for state comparison to date is by adding logic within dbt-core to upgrade older manifests into the now-expected schema.
  • We also need to add a test (like this one) to ensure this doesn't break going forward for older schemas of run_results.json
@martynydbt martynydbt added bug Something isn't working triage regression labels Nov 6, 2023
@github-actions github-actions bot changed the title [Regression] Deferral and Retry fail in 1.7 if you don't have a run *without* deferral using 1.7 first [CT-3326] [Regression] Deferral and Retry fail in 1.7 if you don't have a run *without* deferral using 1.7 first Nov 6, 2023
@martynydbt martynydbt linked a pull request Nov 6, 2023 that will close this issue
5 tasks
@jtcohen6 jtcohen6 removed the triage label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants