Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-3392] [Bug] Windows tests fails with an InternalError/ValueError #9091

Closed
2 tasks done
emmyoop opened this issue Nov 15, 2023 · 0 comments · Fixed by #9090
Closed
2 tasks done

[CT-3392] [Bug] Windows tests fails with an InternalError/ValueError #9091

emmyoop opened this issue Nov 15, 2023 · 0 comments · Fixed by #9090
Assignees
Labels
bug Something isn't working

Comments

@emmyoop
Copy link
Member

emmyoop commented Nov 15, 2023

Is this a new bug in dbt-core?

  • I believe this is a new bug in dbt-core
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

Tests on windows fail

Expected Behavior

Tests on windows pass

Steps To Reproduce

Run CI on windows

Relevant log output

\functional\external_reference\test_external_reference.py .         [  0%]
tests\functional\fail_fast\test_fail_fast_run.py ..                      [  2%]
tests\functional\graph_selection\test_graph_selection.py .
INTERNALERROR> Traceback (most recent call last):
INTERNALERROR>   File "D:\a\dbt-core\dbt-core\.tox\integration\lib\site-packages\_pytest\main.py", line 271, in wrap_session
INTERNALERROR>     session.exitstatus = doit(config, session) or 0
INTERNALERROR>   File "D:\a\dbt-core\dbt-core\.tox\integration\lib\site-packages\_pytest\main.py", line 325, in _main
INTERNALERROR>     config.hook.pytest_runtestloop(session=session)
INTERNALERROR>   File "D:\a\dbt-core\dbt-core\.tox\integration\lib\site-packages\pluggy\_hooks.py", line 493, in __call__
INTERNALERROR>     return self._hookexec(self.name, self._hookimpls, kwargs, firstresult)
INTERNALERROR>   File "D:\a\dbt-core\dbt-core\.tox\integration\lib\site-packages\pluggy\_manager.py", line 115, in _hookexec
INTERNALERROR>     return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
INTERNALERROR>   File "D:\a\dbt-core\dbt-core\.tox\integration\lib\site-packages\pluggy\_callers.py", line 130, in _multicall
INTERNALERROR>     teardown[0].send(outcome)
INTERNALERROR>   File "D:\a\dbt-core\dbt-core\.tox\integration\lib\site-packages\pluggy\_result.py", line 114, in get_result
INTERNALERROR>     raise exc.with_traceback(exc.__traceback__)
INTERNALERROR>   File "D:\a\dbt-core\dbt-core\.tox\integration\lib\site-packages\pluggy\_callers.py", line 77, in _multicall
INTERNALERROR>     res = hook_impl.function(*args)
INTERNALERROR>   File "D:\a\dbt-core\dbt-core\.tox\integration\lib\site-packages\_pytest\main.py", line 350, in pytest_runtestloop
INTERNALERROR>     item.config.hook.pytest_runtest_protocol(item=item, nextitem=nextitem)
INTERNALERROR>   File "D:\a\dbt-core\dbt-core\.tox\integration\lib\site-packages\pluggy\_hooks.py", line 493, in __call__
INTERNALERROR>     return self._hookexec(self.name, self._hookimpls, kwargs, firstresult)
INTERNALERROR>   File "D:\a\dbt-core\dbt-core\.tox\integration\lib\site-packages\pluggy\_manager.py", line 115, in _hookexec
INTERNALERROR>     return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
INTERNALERROR>   File "D:\a\dbt-core\dbt-core\.tox\integration\lib\site-packages\pluggy\_callers.py", line 152, in _multicall
INTERNALERROR>     return outcome.get_result()
INTERNALERROR>   File "D:\a\dbt-core\dbt-core\.tox\integration\lib\site-packages\pluggy\_result.py", line 114, in get_result
INTERNALERROR>     raise exc.with_traceback(exc.__traceback__)
INTERNALERROR>   File "D:\a\dbt-core\dbt-core\.tox\integration\lib\site-packages\pluggy\_callers.py", line 62, in _multicall
INTERNALERROR>     next(wrapper_gen)  # first yield
INTERNALERROR>   File "D:\a\dbt-core\dbt-core\.tox\integration\lib\site-packages\ddtrace\contrib\pytest\plugin.py", line 645, in pytest_runtest_protocol
INTERNALERROR>     _add_start_end_source_file_path_data_to_span(span, test_method_object, test_name)
INTERNALERROR>   File "D:\a\dbt-core\dbt-core\.tox\integration\lib\site-packages\ddtrace\internal\ci_visibility\utils.py", line 40, in _add_start_end_source_file_path_data_to_span
INTERNALERROR>     source_file_path = get_source_file_path_for_test_method(test_method_object)
INTERNALERROR>   File "D:\a\dbt-core\dbt-core\.tox\integration\lib\site-packages\ddtrace\internal\ci_visibility\utils.py", line 15, in get_source_file_path_for_test_method
INTERNALERROR>     source_file_path = os.path.relpath(inspect.getfile(test_method_object))
INTERNALERROR>   File "C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\ntpath.py", line 703, in relpath
INTERNALERROR>     raise ValueError("path is on mount %r, start on mount %r" % (
INTERNALERROR> ValueError: path is on mount 'D:', start on mount 'C:'

Environment

- OS: Windows
- Python: 3.8
- dbt:

Which database adapter are you using with dbt?

No response

Additional Context

This is a bug with our tests, not actual dbt-core code itself. It does not affect dbt running on windows generally. This is from a new release of ddtrace 2.2.0.

Issue in dd-trace-py

@emmyoop emmyoop added bug Something isn't working triage labels Nov 15, 2023
@github-actions github-actions bot changed the title [Bug] Windows tests fails with an InternalError/ValueError [CT-3392] [Bug] Windows tests fails with an InternalError/ValueError Nov 15, 2023
@emmyoop emmyoop mentioned this issue Nov 15, 2023
5 tasks
@dbeatty10 dbeatty10 removed the triage label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants