Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-3432] [spike] investigation - event system should completely control stdout #9174

Open
3 tasks done
nathaniel-may opened this issue Nov 29, 2023 · 1 comment
Open
3 tasks done

Comments

@nathaniel-may
Copy link
Contributor

nathaniel-may commented Nov 29, 2023

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Some dependencies of core and/or adapters do silly things like call print instead of using the python standard logger. This causes a bad experience for users who run with the --quiet flag, and for users who are trying to capture everything to a file. Details and examples can be found in this originating issue: dbt-labs/dbt-snowflake#847

Acceptance Criteria

  • determine if this is possible, and if so what the possibilities are and what the implications are of each possibility
@nathaniel-may nathaniel-may added enhancement New feature or request triage labels Nov 29, 2023
@github-actions github-actions bot changed the title [Feature] event system should completely control stdout [CT-3432] [Feature] event system should completely control stdout Nov 29, 2023
@graciegoheen
Copy link
Contributor

graciegoheen commented Jan 2, 2024

Notes from technical refinement:

  • we use print a lot for debugging, so we should make sure this still works in development
  • how would we stop people from printing? there's other things (like system crash) we'd want to go to stdout
  • this should be an investigation ticket to start, to see if there are any ways to achieve this
  • more context in internal slack thread

@graciegoheen graciegoheen changed the title [CT-3432] [Feature] event system should completely control stdout [CT-3432] [spike] investigation - event system should completely control stdout Jan 2, 2024
@graciegoheen graciegoheen added this to the v1.8 milestone Feb 20, 2024
@martynydbt martynydbt assigned emmyoop and unassigned gshank Feb 22, 2024
@martynydbt martynydbt assigned MichelleArk and QMalcolm and unassigned emmyoop and MichelleArk Apr 6, 2024
@graciegoheen graciegoheen removed this from the v1.8 milestone Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants