Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-3456] Add additional attributes to RelationConfig for use in adapter implementations #88

Closed
MichelleArk opened this issue Dec 5, 2023 · 1 comment
Closed

[CT-3456] Add additional attributes to RelationConfig for use in adapter implementations #88

MichelleArk opened this issue Dec 5, 2023 · 1 comment
Assignees
@colin-rogers-dbt

Comments

@MichelleArk
Copy link
Contributor

No description provided.

This was referenced Dec 5, 2023
Closed
Merged
@github-actions github-actions bot changed the title Add additional attributes to RelationConfig for use in adapter implementations [CT-3456] Add additional attributes to RelationConfig for use in adapter implementations Dec 5, 2023
@colin-rogers-dbt
Copy link
Contributor

colin-rogers-dbt commented Dec 7, 2023 •
edited
Loading

RelationConfig is used to configure create_from method, as we did this against postgres the fields in the class are applicable to that adapter. We need to analyze other adapters and identify missing fields we need.

Example is duckdb source config: https://github.com/duckdb/dbt-duckdb/blob/master/dbt/adapters/duckdb/utils.py#L20

@colin-rogers-dbt colin-rogers-dbt transferred this issue from dbt-labs/dbt-core Feb 14, 2024
@mikealfare mikealfare closed this as not planned Won't fix, can't repro, duplicate, stale Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colin-rogers-dbt colin-rogers-dbt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MichelleArk @mikealfare @colin-rogers-dbt