Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-3518] [Bug] Retry should not print out warning when state path is not specified #9327

Closed
2 tasks done
graciegoheen opened this issue Jan 3, 2024 · 2 comments · Fixed by #9328
Closed
2 tasks done
Assignees
Labels
backport 1.7.latest bug Something isn't working Impact: Exp Medium Severity bug with minor impact that does not have resolution timeframe requirement retry

Comments

@graciegoheen
Copy link
Contributor

graciegoheen commented Jan 3, 2024

Is this a new bug in dbt-core?

  • I believe this is a new bug in dbt-core
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

We decided to add a warning when --state path == --target-path #8160

This would cause dbt core raise a warning in retry when dbt tries to load the previous state. But actually dbt do not need to load all previous state in this case and should not raise such warning

Expected Behavior

We should only load the previous run results, and not print out a warning.

Steps To Reproduce

...

Relevant log output

No response

Environment

- OS:
- Python:
- dbt:

Which database adapter are you using with dbt?

No response

Additional Context

No response

@graciegoheen graciegoheen added bug Something isn't working triage labels Jan 3, 2024
@github-actions github-actions bot changed the title [Bug] we should not require a separate state for retry [CT-3518] [Bug] we should not require a separate state for retry Jan 3, 2024
@graciegoheen graciegoheen added Impact: Exp backport 1.7.latest High Severity bug with significant impact that should be resolved in a reasonable timeframe retry and removed triage labels Jan 3, 2024
@ChenyuLInx
Copy link
Contributor

@graciegoheen after looking at the code closely, I realized my previous description was wrong. Retry would still function in that case but would just always print out an irrelevant warning and load stuff that it do not need.
I updated the issue to make sure it is correct. Hope you don't mind.

@ChenyuLInx ChenyuLInx changed the title [CT-3518] [Bug] we should not require a separate state for retry [CT-3518] [Bug] Retry should not print out warning when state path is not specified Jan 3, 2024
@ChenyuLInx
Copy link
Contributor

Taking off sev 1 as it is only false alarm warning.

@ChenyuLInx ChenyuLInx removed the High Severity bug with significant impact that should be resolved in a reasonable timeframe label Jan 6, 2024
@martynydbt martynydbt added the Medium Severity bug with minor impact that does not have resolution timeframe requirement label Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.7.latest bug Something isn't working Impact: Exp Medium Severity bug with minor impact that does not have resolution timeframe requirement retry
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants