Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create unit tests for SemanticManifest supported by a manifest fixture and utility builders #9665

Closed
1 task done
Tracked by #9649
QMalcolm opened this issue Feb 26, 2024 · 1 comment · Fixed by #9930
Closed
1 task done
Tracked by #9649
Assignees
Labels
enhancement New feature or request

Comments

@QMalcolm
Copy link
Contributor

QMalcolm commented Feb 26, 2024

Housekeeping

  • I am a maintainer of dbt-core

Short description

As part of our Robust Testing Initiative we want to create generalized fixtures for our unit tests to make writing unit tests easier. To that end we want to add or update unit some unit tests to utilize the new fixture. Currently the SemanticManifest class is not unit tested at all, and it only requires a manifest (with some SL nodes).

Acceptance criteria

  • There is a generic manifest unit test fixture
  • There are builders to add SemanticModels, Metrics, and SavedQueries to a manifest
  • There are unit tests for the SemanticManifest
  • Reflect on test coverage of SemanticManifest during review

Suggested Tests

The work is the tests

Impact to Other Teams

None

Will backports be required?

Narp

Context

@QMalcolm QMalcolm added Refinement Maintainer input needed and removed Refinement Maintainer input needed labels Feb 26, 2024
@martynydbt martynydbt added the enhancement New feature or request label Mar 20, 2024
@ChenyuLInx ChenyuLInx self-assigned this Apr 3, 2024
@ChenyuLInx
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants