Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] better error message when running disabled model #9747

Closed
3 tasks done
graciegoheen opened this issue Mar 11, 2024 · 3 comments · Fixed by #9863
Closed
3 tasks done

[Feature] better error message when running disabled model #9747

graciegoheen opened this issue Mar 11, 2024 · 3 comments · Fixed by #9863
Labels
enhancement New feature or request good_first_issue Straightforward + self-contained changes, good for new contributors!

Comments

@graciegoheen
Copy link
Contributor

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature

When you run a disabled model you get this error

21:53:02  Found 468 models, 5 analyses, 720 tests, 6 seeds, 2 operations, 149 sources, 0 exposures, 0 metrics, 954 macros, 0 groups, 0 semantic models
21:53:02  The selection criterion 'log__user_table' does not match any nodes
21:53:02  
21:53:02  Nothing to do. Try checking your model configs and model specification args

Would be better if this model read

21:53:02  Found 468 models, 5 analyses, 720 tests, 6 seeds, 2 operations, 149 sources, 0 exposures, 0 metrics, 954 macros, 0 groups, 0 semantic models
21:53:02  The selection criterion 'log__user_table' matches a disabled node
21:53:02  
21:53:02  Nothing to do. Try checking your model configs and model specification args

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response

@graciegoheen graciegoheen added enhancement New feature or request triage labels Mar 11, 2024
@dbeatty10
Copy link
Contributor

Idea from @dataders -- just add the single word enabled to the log output:

21:53:02  The selection criterion 'log__user_table' does not match any enabled nodes

After discussing with @graciegoheen and @dataders, let's adopt this simple language.

@dbeatty10 dbeatty10 added good_first_issue Straightforward + self-contained changes, good for new contributors! and removed triage labels Apr 2, 2024
@SamuelBFavarin
Copy link
Contributor

SamuelBFavarin commented Apr 4, 2024

Hi @dbeatty10, I would like to start to contribute to dbt-core, and this issue looks like a good opportunity to begin. Would you mind if I open a PR updating this log message?

@dataders
Copy link
Contributor

dataders commented Apr 4, 2024

@SamuelBFavarin here's the offending line. Check out our contributing.md to get started!

return f"The selection criterion '{self.spec_raw}' does not match any nodes"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good_first_issue Straightforward + self-contained changes, good for new contributors!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants