Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix query comments test #9860

Closed
2 tasks done
damian3031 opened this issue Apr 5, 2024 · 0 comments · Fixed by #9861
Closed
2 tasks done

[Bug] Fix query comments test #9860

damian3031 opened this issue Apr 5, 2024 · 0 comments · Fixed by #9861
Labels
bug Something isn't working

Comments

@damian3031
Copy link
Contributor

Is this a new bug in dbt-core?

  • I believe this is a new bug in dbt-core
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

test_query_comments.py::BaseMacroArgsQueryComments::test_matches_comment is comparing dbt-core version with dbt adapter version, which is wrong assumtion after decoupling dbt adapters from dbt-core version.

Expected Behavior

No error should be raised for different versions of dbt adapter and dbt-core.

Steps To Reproduce

  1. Have different versions of dbt adapter and dbt-core.
  2. Run test_query_comments.py::BaseMacroArgsQueryComments::test_matches_comment test

Relevant log output

No response

Environment

- OS: macOS
- Python: 3.12
- dbt-core: 1.8.0b2

Which database adapter are you using with dbt?

other (mention it in "Additional Context")

Additional Context

No response

@damian3031 damian3031 added bug Something isn't working triage labels Apr 5, 2024
@damian3031 damian3031 mentioned this issue Apr 5, 2024
5 tasks
@dbeatty10 dbeatty10 removed the triage label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants