Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searches can be typed in before search is initialised #166

Closed
joellabes opened this issue Jan 6, 2021 · 2 comments
Closed

Searches can be typed in before search is initialised #166

joellabes opened this issue Jan 6, 2021 · 2 comments
Labels
bug Something isn't working Stale

Comments

@joellabes
Copy link
Contributor

Describe the bug

In large docs projects, it takes a couple of seconds after the docs page has loaded for the nodes to be ready in the left hand sidebar and in search. This means I pretty regularly open the docs site, start typing a query, and get no results until I delete and re-enter it.

Steps To Reproduce

  1. Have a large docs site (I haven't been able to report with jaffle_shop)
  2. Open it up, and immediately click into the search bar and type a query
  3. When everything does load, see that all nodes display as search results, even though they're not relevant.

Expected behavior

  • Either to not be able to search until search is ready
  • or when everything does load, re-run the search using the existing search string

Screenshots and log output

2021-01-06_15-02-10.mp4
@joellabes joellabes added the bug Something isn't working label Jan 6, 2021
@joellabes
Copy link
Contributor Author

I snuck a fix in for this at dc20dee as part of #162, but happy to rework it as needed

@github-actions
Copy link
Contributor

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please remove the stale label or comment on the issue, or it will be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant