Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] dbt Docs DAG visualisation should include (generic) test nodes #220

Closed
1 task done
joellabes opened this issue Oct 19, 2021 · 5 comments
Closed
1 task done
Labels

Comments

@joellabes
Copy link
Contributor

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

This is beautiful, and makes it easy to reason about the selection of tests as first-class participants in the DAG, as well as the behaviour of dbt build.
image

Tests should be allowed to appear in the DAG view in dbt Docs (probably off by default).

Describe alternatives you've considered

No response

Who will this benefit?

Are you interested in contributing this feature?

Nah 😞

Anything else?

No response

@jtcohen6
Copy link
Contributor

@joellabes I agree, this would be quite useful!

There's no change here from dbt-core's perspective. Generic tests are included in the nodes dictionary of manifest.json, same as singular tests and many other resource types. The logic to exclude them from the DAG viz lives solely in dbt-docs, so that's where I'm going to transfer this issue.

(Similarly, if we wanted to include generic test nodes in the dbt Cloud IDE Lineage view, we'd need to make that change in dbt Cloud.)

@jtcohen6 jtcohen6 transferred this issue from dbt-labs/dbt-core Oct 21, 2021
@JC-Lightfold
Copy link

Would love this - hugely valuable for securing data estate at enterprise level. If this was an easy add, it would be high value for the effort @jtcohen6 @joellabes

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please remove the stale label or comment on the issue, or it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 8, 2022
@joellabes joellabes removed the Stale label Sep 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 8, 2023
@github-actions
Copy link
Contributor

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants