Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2200] Model view: when available, display model owner in dbt-docs #377

Closed
Tracked by #6747
MichelleArk opened this issue Feb 1, 2023 · 3 comments · Fixed by #382
Closed
Tracked by #6747

[CT-2200] Model view: when available, display model owner in dbt-docs #377

MichelleArk opened this issue Feb 1, 2023 · 3 comments · Fixed by #382

Comments

@MichelleArk
Copy link
Contributor

MichelleArk commented Feb 1, 2023

In the model view (/model/{model_id}) of dbt-docs, display the model owner (by name?) when available.

If a model is part of a group, its owner information should be available as part of the group property.

Screen Shot 2023-01-31 at 11 18 20 PM

@github-actions github-actions bot changed the title Model view: when available, display model owner in dbt-docs [CT-1988] Model view: when available, display model owner in dbt-docs Feb 1, 2023
@emmyoop
Copy link
Member

emmyoop commented Feb 6, 2023

If a model has a group, it will have an owner. If it's not in a group and doesn't have an owner then use the value we use today (from WH).

Will require looking up the owner as defined in the group.

@emmyoop
Copy link
Member

emmyoop commented Feb 27, 2023

What is the owner? Do we want to add a field per owner type(name, email, slack, etc)? Have some kind of ranking? Use name is available, then email, then... and if none are available use the warehouse value.

Exposures currently list both the owner name and the owner email and dynamically hide one if it's not available.

Screen Shot 2023-02-27 at 8 27 53 AM

Screen Shot 2023-02-27 at 8 29 10 AM

@aranke
Copy link
Member

aranke commented Feb 27, 2023

I've been confused by the owner object in the past, so here are my 2c:

  1. Flatten it to a Git-style simple string User <user@domain.com>.
  2. Keep it simple, Slack/GitHub/other social handles are overkill.

@emmyoop emmyoop transferred this issue from dbt-labs/dbt-core Feb 27, 2023
@github-actions github-actions bot changed the title [CT-1988] Model view: when available, display model owner in dbt-docs [CT-2200] [CT-1988] Model view: when available, display model owner in dbt-docs Feb 27, 2023
@emmyoop emmyoop self-assigned this Feb 27, 2023
@emmyoop emmyoop changed the title [CT-2200] [CT-1988] Model view: when available, display model owner in dbt-docs [CT-2200] Model view: when available, display model owner in dbt-docs Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants