Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2740] Ensure semantic models & metrics are included in DAG viz #431

Closed
Tracked by #8125
jtcohen6 opened this issue Jun 26, 2023 · 2 comments · Fixed by #444
Closed
Tracked by #8125

[CT-2740] Ensure semantic models & metrics are included in DAG viz #431

jtcohen6 opened this issue Jun 26, 2023 · 2 comments · Fixed by #444
Assignees
Labels
enhancement New feature or request

Comments

@jtcohen6
Copy link
Contributor

Minimum viable work to ensure ongoing parity for metrics (old) & semantic models (new):

  • dedicated page for each node
  • DAG viz
@jtcohen6 jtcohen6 added the enhancement New feature or request label Jun 26, 2023
@github-actions github-actions bot changed the title Ensure semantic models & metrics are included in DAG viz [CT-2740] Ensure semantic models & metrics are included in DAG viz Jun 26, 2023
@emmyoop
Copy link
Member

emmyoop commented Aug 3, 2023

@jtcohen6 I need to clarify what you're looking for here. Does it include everything below? Is the wording what you'd expect? The screenshots below are all of the existing metrics functionality.

  1. Semantic models get their own heading under Project,Semantic Models, same as Metrics have

Screenshot 2023-08-03 at 4 53 52 PM

  1. Semantic models get their own page with their own url (http://localhost:8080/#!/semantic_models/...)

Screenshot 2023-08-03 at 4 55 21 PM

  1. Represent a semantic model as another part of the DAG, same as metric is distinguished as a node in pink below.

Screenshot 2023-08-03 at 5 01 28 PM

  1. Be able to select on the semantic model in the DAG
    Screenshot 2023-08-03 at 5 01 07 PM

Anything else?

@github-actions github-actions bot added the triage label Aug 3, 2023
@jtcohen6 jtcohen6 removed the triage label Aug 7, 2023
@jtcohen6 jtcohen6 added this to the y milestone Aug 7, 2023
@jtcohen6
Copy link
Contributor Author

jtcohen6 commented Aug 7, 2023

As discussed in Slack, priority order for parity is:

  1. DAG viz is still working when you add metrics + semantic models
  2. metrics still populate pages with relevant info
  3. semantic models have dedicated pages (feels ok to kick this out of scope)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants