Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

On start hook inserting before seed table created #5

Open
mpcarter opened this issue Mar 13, 2020 · 2 comments
Open

On start hook inserting before seed table created #5

mpcarter opened this issue Mar 13, 2020 · 2 comments

Comments

@mpcarter
Copy link

I've been staring at this for some time trying to figure out if I am overlooking something. From what I can tell (and confirm from Consideration with Hooks ) dbt seed will call the on-run-start hook prior to creating any tables to load the seed data. However, the test defined in dbt-integration-tests is trying to insert a row into a seed table during the on-run-start hook.

https://github.com/fishtown-analytics/dbt-integration-tests/blob/a0333529184a7065e3d4add2ec694d4acc543a57/features/003_hooks.feature#L36-L41

https://github.com/fishtown-analytics/dbt-integration-tests/blob/a0333529184a7065e3d4add2ec694d4acc543a57/features/003_hooks.feature#L62-L63

So my test keeps failing because you cannot insert data into a table that does not exist yet.

@jtcohen6
Copy link
Contributor

@mpcarter Is this an issue you're running into on the Vertica adapter you're working on?

I'd say really quickly that:

  • This repo is a work in progress, and really more a proof of concept than a finalized answer for testing new dbt adapters
  • We currently don't run the 003_hooks.feature for dbt-spark testing
  • @drewbanin and I are in the midst of a conversation about how best to federate integration and end-to-end tests between dbt-core and adapter plugins. Most likely, it will look less like this repo, and more like splitting out the tests currently defined here. We would then allow each plugin to define which tests it needs to override, which features are unsupported (= don't run those tests at all), and which tests it should run in addition to the core set.

@mpcarter
Copy link
Author

@mpcarter Is this an issue you're running into on the Vertica adapter you're working on?

Yes.

Thanks for the response. Good to know I'm not going crazy. I'm going to attempt some real world testing then.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants