Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle/flag hard-coded references #240

Closed
deanna-minnick opened this issue Dec 1, 2022 · 1 comment · Fixed by #246
Closed

Handle/flag hard-coded references #240

deanna-minnick opened this issue Dec 1, 2022 · 1 comment · Fixed by #246
Labels
enhancement New feature or request

Comments

@deanna-minnick
Copy link
Contributor

Describe the feature

I would love for this package to be able to handle (and flag?) hard-coded references (ie raw.stripe.payment vs. {{ source ('stripe', 'payment') }). I specifically noticed that 'fct_unused_sourcescurrently returns sources that are accessed only via hard-coded references instead of thesourceorref` macros. There may be other applications for this functionality within the package as well.

Describe alternatives you've considered

The minimum response to this issue would be to add a note to the readme regarding the results of the fct_unused_sources model to include this possibility. A value-add in that documentation could be a recommendation about how to discern whether the sources are truly unused vs. accessed through hard-coding. For instance, in my case I used the list generated by fct_root_models as a starting place when looking for hard-coded references.

Additional context

This should apply to multiple databases.

Who will this benefit?

This would benefit anyone with hard-coded references in their project, allowing them to systematically transition to appropriate alternatives (source and ref functions).

Are you interested in contributing this feature?

Sure! And I'd be glad for some discussion/input around how to approach solving this.

@deanna-minnick deanna-minnick added the enhancement New feature or request label Dec 1, 2022
@graciegoheen
Copy link
Collaborator

Hi! Didn't realize we already have an old issue about this - let's move discussion over there. I'm going to try to tackle this today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants