Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-1218] [Bug] The query-comment statement not included in incremental Merge query #270

Closed
2 tasks done
pempey opened this issue Sep 20, 2022 · 2 comments
Closed
2 tasks done
Labels
bug Something isn't working

Comments

@pempey
Copy link

pempey commented Sep 20, 2022

Is this a new bug in dbt-snowflake?

  • I believe this is a new bug in dbt-snowflake
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

When reviewing the query text in snowflake for incremental model executions the query-comment is not present in the MERGE command but it is present in the CREATE temp table command.

Expected Behavior

I would expect all queries executed by dbt to include the defined query-comment

Steps To Reproduce

  1. dbt-snowflake version 1.1
  2. define a query-comment in the dbt-project.yml
  3. create an incremental model
  4. run the incremental model first to build the table and a second time to invoke a merge action.
  5. review dbt logs or snowflake query logs

Relevant log output

No response

Environment

- OS:macOS 11.6.6
- Python: 3.8.6
- dbt-core: 1.1.0
- dbt-snowflake: 1.1.0

Additional Context

No response

@pempey pempey added bug Something isn't working triage labels Sep 20, 2022
@github-actions github-actions bot changed the title [Bug] The query-comment statement not included in incremental Merge query [CT-1218] [Bug] The query-comment statement not included in incremental Merge query Sep 20, 2022
@jtcohen6
Copy link
Contributor

jtcohen6 commented Sep 20, 2022

Hey @pempey - I believe this was fixed (#153)!

That fix was included in v1.2 — could you try upgrading, and see whether you see the query comment show up on the merge statement as well?

(Dupe of #140)

@jtcohen6 jtcohen6 added duplicate and removed triage labels Sep 20, 2022
@pempey
Copy link
Author

pempey commented Sep 20, 2022

@jtcohen6 I can confirm that upgrading to v1.2. solved the issue. Not sure why I did not see the other issues but thank you for helping me resolve this.

@pempey pempey closed this as completed Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants