-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CT-302] [Spike] Benchmark perf for show tables
, show views
#296
Comments
show tables
, show views
show tables
, show views
In particular we want to benchmark / bake-off achieving the same outcome via these two competing approaches:
I can share more context when we grab some time synchronously! |
Experimental code to play around with during our pairing time tomorrow:
After some limited local testing, I'm finding option 1 to be faster, but it would be worth testing against more project/database shapes. Update:
|
After some initial local testing (not yet scientific benchmarking): Approach 2 ( Principal risk of approach 1: dbt groups its cached relations by schema. If we run Principal risk of approach 2: We're getting less info at cache time than before. Crucially, we no longer get the file format of each table, which we need at runtime for conditional logic in materializations (i.e. There are still good reasons to want I don't feel this is enough, in its own right, to confidently move ahead with approach 2, but it's certainly the direction in which I'm now leaning. The performance seems better at scale, and the risks (really limitations) are better understood. |
More context here: #228
We want to be able to benchmark perf for these 2 calls to see if we should make improvements here to help with perf.
The text was updated successfully, but these errors were encountered: