Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-456] Make internal macros use macro dispatch to be overridable in child adapters. #319

Closed
ueshin opened this issue Apr 4, 2022 · 1 comment · Fixed by #320
Closed
Labels
enhancement New feature or request

Comments

@ueshin
Copy link
Contributor

ueshin commented Apr 4, 2022

Describe the feature

A child adapter, e.g., dbt-databricks, wants to override the internal macros for creating table, such as file_format_clause, options_clause, but currently it's unclear whether they are overridable or not.
We should explicitly use macro dispatch mechanism.

Describe alternatives you've considered

Just use the same macro names, but it's not clear whether the proper macros will be used.

Additional context

The discussion is databricks/dbt-databricks#72 (comment)

Who will this benefit?

For a child adapter maintainers to make sure they can override the macros.

Are you interested in contributing this feature?

Yes.

@ueshin ueshin added enhancement New feature or request triage labels Apr 4, 2022
@github-actions github-actions bot changed the title Make internal macros use macro dispatch to be overridable in child adapters. [CT-456] Make internal macros use macro dispatch to be overridable in child adapters. Apr 4, 2022
@jtcohen6 jtcohen6 removed the triage label Apr 5, 2022
@jtcohen6
Copy link
Contributor

jtcohen6 commented Apr 5, 2022

@ueshin Thanks for opening the issue + PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants