Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-1085] Integration tests fail due to schema for python models temp table is not correctly generated #441

Closed
ChenyuLInx opened this issue Aug 25, 2022 · 4 comments · Fixed by #445
Closed

[CT-1085] Integration tests fail due to schema for python models temp table is not correctly generated #441

ChenyuLInx opened this issue Aug 25, 2022 · 4 comments · Fixed by #445
Labels
feature:python-models issues related to python model type:bug Something isn't working

Comments

@ChenyuLInx
Copy link
Contributor

Describe the bug

There are two different tests fail on Circle CI
https://app.circleci.com/pipelines/github/dbt-labs/dbt-spark/1255/workflows/9b266aaa-b685-47df-84c2-410516a7c4d7/jobs/5022
https://app.circleci.com/pipelines/github/dbt-labs/dbt-spark/1255/workflows/9b266aaa-b685-47df-84c2-410516a7c4d7/jobs/5021
One of them seems like issue with permission/database for tmp table. The other one needs more digging

Steps To Reproduce

Running the Circle CI test

Expected behavior

Circle CI pass
@ChenyuLInx ChenyuLInx added type:bug Something isn't working triage:product labels Aug 25, 2022
@github-actions github-actions bot changed the title Integration tests failed on Circle CI [CT-1085] Integration tests failed on Circle CI Aug 25, 2022
@ChenyuLInx
Copy link
Contributor Author

Looks like rerun tests at #440 succeeded. Maybe this is already fixed?

@ChenyuLInx
Copy link
Contributor Author

https://app.circleci.com/pipelines/github/dbt-labs/dbt-spark/1278/workflows/cd402d4e-6e7b-4040-9763-eba0f73aa578/jobs/5155 failed again on recent test, looks like it might be caused by dbt-labs/dbt-core#5685?

@ChenyuLInx ChenyuLInx added feature:python-models issues related to python model and removed triage:product labels Aug 30, 2022
@ChenyuLInx ChenyuLInx changed the title [CT-1085] Integration tests failed on Circle CI [CT-1085] Integration tests fail due to schema for python models temp table is not correctly generated Aug 30, 2022
@leahwicz
Copy link
Contributor

@ChenyuLInx I was going to release the second beta for Spark today but should I hold off? I can always release a 3rd beta as well if that is a better path forward

@ChenyuLInx
Copy link
Contributor Author

ChenyuLInx commented Aug 30, 2022 •
edited
Loading

@leahwicz Let's leave this as a third Beta, currently this would only affect users who doesn't have access to default schema. The fix might not be a small lift, still looking into it

@ChenyuLInx ChenyuLInx mentioned this issue Aug 30, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature:python-models issues related to python model type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

set tmp relation with proper schema dbt-labs/dbt-spark
2 participants
@ChenyuLInx @leahwicz