Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAP-405] [Feature] Use server_side_parameters as SparkSession config in Spark "session" mode #690

Closed
3 tasks done
alarocca-apixio opened this issue Mar 21, 2023 · 4 comments · Fixed by #823
Closed
3 tasks done
Assignees
Labels
type:enhancement New feature or request

Comments

@alarocca-apixio
Copy link
Contributor

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt-spark functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Configuration for server_side_parameters already exists in the Spark configuration. However, these are currently unused in Spark "session" mode. We can pass these into SessionConnectionWrapper and then, when building the SparkSession, we can pass them as Spark "config":

for k, v in server_side_parameters.items():
            builder = builder.config(k, v)

Describe alternatives you've considered

We've tried Spark via Thrift, but this doesn't support all of our necessary use cases, such as configuring KMS encryption for the jobs.

Who will this benefit?

This will enable users to flexibly control the SparkSession that is created, giving users the ability to inject any parameters desired into the SparkSession.

Are you interested in contributing this feature?

Yes

Anything else?

No response

@github-actions github-actions bot changed the title [Feature] Use server_side_parameters as SparkSession config in Spark "session" mode [ADAP-405] [Feature] Use server_side_parameters as SparkSession config in Spark "session" mode Mar 21, 2023
@Fleid
Copy link
Contributor

Fleid commented Mar 24, 2023

Hey @alarocca-apixio, could you please check this discussion, I'm trying to regroup all the threads on that topic in one place.
Please let me know if the plan works for you, before we can decide to move forward with this specific issue.

@Fokko
Copy link
Contributor

Fokko commented May 15, 2023

@alarocca-apixio @Fleid Any progress on this? I would love to see this added. Happy to help on this one, just commented on the PR.

@Fleid
Copy link
Contributor

Fleid commented May 24, 2023

I asked @JCZuurmond to weigh in on the topic, but we haven't had time to catch-up.
Any update on your side Cor?

@JCZuurmond
Copy link
Collaborator

See PR for update 👆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request
Projects
None yet
4 participants