-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite type_*
macros to use built-in adapter capabilities
#598
Labels
enhancement
New feature or request
Comments
This was referenced Jun 1, 2022
This was referenced Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Split out from #577 + #597
Describe the feature
In
dbt-utils
: Rewrite the type_* macros to use each adapter'sColumn
object. Think about whether it makes sense to push these macro into dbt-core as well, as a sugarier interface over the underlying Python methods.Potential follow-up work in core + plugins:
Column
types as needed (e.g. [CT-636] [Bug] Postgres unlimited varchar default to varchar(256) dbt-core#5238)agate
type conversion methods withColumn
class type translationDescribe alternatives you've considered
Leave current
dbt_utils.type_*
macros as they areAdditional context
Yes, database-specific!
Who will this benefit?
dbt_utils.type_*
macros (their own model SQL / installed package code) andColumn
-object behavior built into dbt's handling for, e.g., column type expansion in incremental models. It'd be better if these both pulled from the same set of information.Are you interested in contributing this feature?
Yes!
The text was updated successfully, but these errors were encountered: