Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite type_* macros to use built-in adapter capabilities #598

Closed
jtcohen6 opened this issue Jun 1, 2022 · 0 comments · Fixed by #586
Closed

Rewrite type_* macros to use built-in adapter capabilities #598

jtcohen6 opened this issue Jun 1, 2022 · 0 comments · Fixed by #586
Assignees
Labels
enhancement New feature or request

Comments

@jtcohen6
Copy link
Contributor

jtcohen6 commented Jun 1, 2022

Split out from #577 + #597

Describe the feature

In dbt-utils: Rewrite the type_* macros to use each adapter's Column object. Think about whether it makes sense to push these macro into dbt-core as well, as a sugarier interface over the underlying Python methods.

Potential follow-up work in core + plugins:

Describe alternatives you've considered

Leave current dbt_utils.type_* macros as they are

Additional context

Yes, database-specific!

Who will this benefit?

  • People relying on a mixture of dbt_utils.type_* macros (their own model SQL / installed package code) and Column-object behavior built into dbt's handling for, e.g., column type expansion in incremental models. It'd be better if these both pulled from the same set of information.
  • All of us, in the long run, by consolidating these types and keeping them more consistent

Are you interested in contributing this feature?

Yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant