Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Allow metrics in semantic layer filters #5142

Closed
FishtownBuildBot opened this issue Mar 22, 2024 · 5 comments
Closed

[Core] Allow metrics in semantic layer filters #5142

FishtownBuildBot opened this issue Mar 22, 2024 · 5 comments
Assignees
@mirnawong1
Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core dbt-core v1.8 improvement Use this when an area of the docs needs improvement as it's currently unclear size: medium This change will take up to a week to address
Milestone
dbt Core v1.8 Doc...

Comments

@FishtownBuildBot
Copy link

FishtownBuildBot commented Mar 22, 2024 •
edited by dbeatty10
Loading

At a minimum, update body to include a link to the page on docs.getdbt.com requiring updates and what part(s) of the page you would like to see updated.

Issue: dbt-labs/dbt-core#9804
Pull request: dbt-labs/dbt-core#9773
@FishtownBuildBot FishtownBuildBot mentioned this issue Mar 22, 2024
Merged
5 tasks
@runleonarun runleonarun added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear dbt Core The changes proposed in this issue relate to dbt Core labels Mar 22, 2024
@runleonarun
Copy link
Collaborator

@graciegoheen @rpourzand It look like this is a change going out for 1.8 (but also backwards compatible.) Let me know if that sounds right to you!
cc @mirnawong1

@mirnawong1
Copy link
Contributor

hey team, this pr #5309 addresses using metrics in filters for metrics. however i think i should add the syntax for measures and saved queries.

@mirnawong1
Copy link
Contributor

cc @courtneyholcomb

@mirnawong1
Copy link
Contributor

Confirmed with Courtney to wait on this until the SL team confirm this feature is in metricflow. currently it's in dbt core but not in mf yet.

@nataliefiann nataliefiann added the size: medium This change will take up to a week to address label Sep 10, 2024
@nghi-ly nghi-ly changed the title Docs Changes Needed from dbt-core PR #9773 [Core] Docs Changes Needed from dbt-core PR #9773 Sep 13, 2024
@dbeatty10 dbeatty10 changed the title [Core] Docs Changes Needed from dbt-core PR #9773 [Core] Allow metrics in semantic layer filters Oct 1, 2024
@mirnawong1
Copy link
Contributor

fixed here: https://docs.getdbt.com/docs/build/metrics-overview#filters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mirnawong1 mirnawong1

Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core dbt-core v1.8 improvement Use this when an area of the docs needs improvement as it's currently unclear size: medium This change will take up to a week to address
Projects
None yet
Milestone
dbt Core v1.8 Documentation
Development

No branches or pull requests
4 participants
@runleonarun @FishtownBuildBot @mirnawong1 @nataliefiann