Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to support dbt-core v1.5.0 #347

Closed
2 of 4 tasks
dataders opened this issue Apr 19, 2023 · 10 comments
Closed
2 of 4 tasks

upgrade to support dbt-core v1.5.0 #347

dataders opened this issue Apr 19, 2023 · 10 comments

Comments

@dataders
Copy link
Collaborator

dataders commented Apr 19, 2023

Background

The latest version of dbt Core,dbt-core==1.5.0rc1, was published on April 13, 2023 (PyPI | Github).

How to upgrade

dbt-labs/dbt-core#7213 is an open discussion with more detailed information. If you have questions, please put them there!

The above linked guide has more information, but below is a high-level checklist of work that would enable a successful 1.5.0 release of your adapter.

  • Add support Python 3.11 (if you haven't already)
  • Add support for relevant tests (there's a lot of new ones!)
  • Add support model contracts
  • Add support for materialized views (this likely will be bumped to 1.6.0)

the next minor release: 1.6.0

FYI, dbt-core==1.6.0 is expected to be released at the end of July, with a release cut at least two weeks prior.

@sdebruyn
Copy link
Member

we should look at #289 now that there is a test for it

@sdebruyn sdebruyn self-assigned this May 19, 2023
@sdebruyn sdebruyn added this to the v1.5.0 milestone May 19, 2023
@romiof
Copy link

romiof commented May 22, 2023

I've one question...

With support to dbt 1.5.x, will be possible to create constraints at table / incremental materializations?

@sdebruyn
Copy link
Member

@romiof Yes, that should be part of it

@virgilp
Copy link

virgilp commented Jun 29, 2023

Any idea when dbt-sqlserver will support 1.5 ?

@alison985
Copy link

alison985 commented Jul 18, 2023

The following error is also blocking using dbt 1.5.2 and dbt-sqlserver.

ImportError: cannot import name '_make_ref_key_msg' from 'dbt.adapters.cache' (/usr/local/lib/python3.11/site-packages/dbt/adapters/cache.py)

Edit: Add a link to the relevant dbt-core commit.

@sdebruyn
Copy link
Member

@virgilp

Any idea when dbt-sqlserver will support 1.5 ?

#441 should shed some light on the update

@trymzet
Copy link

trymzet commented Sep 21, 2023

Bumping, would be great to at least have some clue when it might be coming, since it seems it's pending some major refactoring effort?

If it's going to take another few months, someone in the community might want to pick up and complete #390 as I think 1.5 has a bunch of new useful features.

@DVAlexHiggs
Copy link

DVAlexHiggs commented Oct 18, 2023

Any news on this? We (the AutomateDV dbt package) support SQLServer and are currently unable to upgrade from 1.4, 1.5, 1.6 & 1.7 as we wanted to wait for all adapters to support these new versions. If this isn't releasing any time soon we will need to release without up-to-date support for SQLServer. I understand this is community supported and it takes time - just want to know either way

@trymzet
Copy link

trymzet commented Jan 24, 2024

For anyone still looking, it looks like 1.7 will be implemented soon, see #461

@cody-scott
Copy link
Collaborator

Closing as 1.8 out now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants