-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to dispatch in dbt v0.20 #52
Comments
@jtcohen6 -- thanks for the heads up! you're right that the end-user experience will change, but this will affect our integration tests. I think making these changes will allow things to work. my questions are:
tsql-utils/integration_tests/dbt_utils/dbt_project.yml Lines 19 to 20 in 28822f1
tsql-utils/integration_tests/dbt_date/dbt_project.yml Lines 20 to 23 in 28822f1
tsql-utils/integration_tests/dbt_expectations/dbt_project.yml Lines 19 to 23 in 28822f1
tsql-utils/integration_tests/dbt_audit_helper/dbt_project.yml Lines 20 to 21 in 28822f1
|
@swanderz Really good questions.
I thought about this, and realized - you could include both syntaxes if you wanted! As soon as you're running dbt v0.19.2 or higher, this should work just fine:
If you've installed the latest version of But I don't think this will even be an issue, because each of the four packages for which tsql-utils provides compatibility—
So as soon as you're running your integration tests on dbt v0.20.0, and against new compliant package versions, you could make a hard cutover to the new syntax.
The code that's actually in Again, because there's going to be a clear cutover from pre-v0.20 support to post-v0.20 support in these other packages, I don't think any user should find themselves in the awkward place of running dbt v0.19.1 with a brand-new version of these packages, or running v0.20.0 with an old version of these packages. So I don't think there's any compatibility matrix for you to document, really. It's more like: If you're using dbt v0.18 or v0.19, use this old syntax ( |
Carefull with the typo there! |
Ah! Thanks for the catch, just edited above |
Hey T-SQL team!
Given that this package exists alongside dispatch, but doesn't dispatch macros itself, I think this will only require a change to the README. Once users and packages have upgraded to the new dispatch syntax in dbt v0.20, they'll want to specify a first-order project config in
dbt_project.yml
:Instead of:
Two crucial differences in the new syntax:
dbt_utils
, they should only specify that one.In the meantime, there is backwards compatibility for the old syntax, so users on old versions of dbt, or using old versions of packages, can still specify those vars.
The text was updated successfully, but these errors were encountered: