Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't install brr in windows #34

Closed
davesnx opened this issue Feb 13, 2022 · 7 comments
Closed

Can't install brr in windows #34

davesnx opened this issue Feb 13, 2022 · 7 comments
Labels
question Further information is requested

Comments

@davesnx
Copy link

davesnx commented Feb 13, 2022

Hey @dbuenzli

I started using brr and it's great, thanks for the effort. It's not a blocker for my project, but I still wanted to report it just in case there's something broken for Windows users.

I'm using esy but I believe have not much to do here, but when building brr in Windows breaks with the following: https://github.com/davesnx/query-json/runs/5175859022?check_suite_focus=true#step:10:32

Brr version: 0.0.2
esy: 0.6.10

@dbuenzli
Copy link
Owner

I don't know. I'm not familiar with esy.

But I don't think there should be a particular particular problem on windows. brr has no system dependencies.

You may want to check with the people in charge of esy's package repository.

@dbuenzli dbuenzli added the question Further information is requested label Feb 13, 2022
@dbuenzli
Copy link
Owner

dbuenzli commented Feb 14, 2022

I had a closer look, roughly I suspect that esy is unable to create the _build directory. This seems to lead to the ocamlbuild plugin being created in the source tree, which leads to ocamlbuild hygiene violation.

I don't think the error is on this side. Feel free to reopen with further details if you think it is.

@Et7f3
Copy link

Et7f3 commented Feb 14, 2022

brr is pulled directly from opam repository: https://github.com/davesnx/query-json/blob/753f4f3c0386907e453cdba6ce6f38e79be668f7/esy.lock/index.json#L1318-L1348

esy expose DUNE_BUILD_DIR for dune to get a writable folder.
Where is this folder created so the call can be adapted.

@dbuenzli
Copy link
Owner

This folder is created by ocamlbuild.

@ManasJayanth
Copy link

This issue is only seen in ocamlbuild 0.14.1 and not on 0.14.0

@dbuenzli
Copy link
Owner

Not sure exactly what changed, tut this, in the new release, seems to deal with folders ocaml/ocamlbuild#302 you may want to check that.

These CI systems, without access to the build dir, make it hard to see what happens and what the problem is exactly. I think you should try to reproduce that on a machine and look around.

@dbuenzli
Copy link
Owner

Keep an eye on this discussion ocaml/ocamlbuild#316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants