Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid github url when the version contains a + #113

Open
ghost opened this issue May 19, 2017 · 3 comments
Open

Invalid github url when the version contains a + #113

ghost opened this issue May 19, 2017 · 3 comments

Comments

@ghost
Copy link

ghost commented May 19, 2017

When I ran topkg opam submit to submit the 1.0+beta9 of jbuilder I got a 404. I had to change the last part of the url generated by topkg opam pkg from jbuilder-1.0+beta9.tbz to jbuilder-1.0.beta9.tbz.

@dbuenzli
Copy link
Owner

Did you get were this came from ? Is github replacing + with . ? What archive name does topgk distrib generate ?

@ghost
Copy link
Author

ghost commented May 23, 2017

It seems that github is indeed replacing the + by a .. This is the full URL where the archive in question is available on github: https://github.com/janestreet/jbuilder/releases/download/1.0%2Bbeta9/jbuilder-1.0.beta9.tbz

topkg distrib generates this name: jbuilder-1.0+beta9.tbz.

@dbuenzli
Copy link
Owner

Annoying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant